Skip to content

Conversation

@dpup
Copy link
Owner

@dpup dpup commented May 30, 2024

Please review the following commits I made in branch dan/delete-with-params:

0047159 (2024-05-30 16:54:13 -0700)
Support query params on DELETE requests, closes #29

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@dpup dpup merged commit ef9f14b into main May 31, 2024
@dpup dpup deleted the dan/delete-with-params branch May 31, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow query params on delete requests

1 participant